Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C# benchmarks not being able to be loaded, and implement the ability to change the benchmark time limit #82

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix C# benchmarks not being able to be loaded, and implement the ability to change the benchmark time limit #82

merged 2 commits into from
Jun 28, 2024

Conversation

OverloadedOrama
Copy link
Contributor

Continuation of #73, fixes a crash when running C# physics benchmarks. Also sets the C# physics benchmarks to 10 seconds.

@OverloadedOrama
Allow the benchmark time limit to be changed by C# scripts
bde9483 
Continuation of godotengine#73, fixes a crash when running C# physics benchmarks. Also sets the C# physics benchmarks to 10 seconds.
@OverloadedOrama
Fix C# benchmarks not being loaded
420bd4f
@OverloadedOrama
Copy link
Contributor Author

OverloadedOrama commented Jun 25, 2024 •
edited
Loading

It seems that godotengine/godot#91557 may have led to C# benchmarks not being able to be loaded, as now Engine.has_singleton("GodotSharp") always returns false. I changed the condition to ClassDB.class_exists(&"CSharpScript"), which seems to be working fine. I'm not sure if there's a better way to check if C# is available or not.

@OverloadedOrama OverloadedOrama changed the title Allow the benchmark time limit to be changed by C# scripts Fix C# benchmarks not being able to be loaded, and implement the ability to change the benchmark time limit Jun 25, 2024
@Calinou Calinou added the bug label Jun 26, 2024
@OverloadedOrama OverloadedOrama mentioned this pull request Jun 28, 2024
Merged
Calinou
Calinou approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit cdea241 into godotengine:main Jun 28, 2024
@OverloadedOrama OverloadedOrama deleted the fix-c-sharp-physics branch June 28, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OverloadedOrama @Calinou