[C#] Unexpose GodotSharp
#91557
Merged
[C#] Unexpose GodotSharp
#91557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class seems to have been exposed accidentally, and breaks documentation on non-mono builds, requiring hacks
|
I don't think we need to re-expose |
AThousandShips
force-pushed
the
dotnet_doc_fix
branch
from
dbeee93 to
aff2e47
Compare
|
Thanks! |
|
Thank you! |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in chat
As an optional addition I exposed theis_runtime_initializedmethod as a static method onCSharpScript, asCSharpLanguageisn't exposed that was the best place I could think of, if we do need to expose it in the first placeAlternatively, for an even hackier approach than the existing one we could create a dummy class in the editor docs to handle this, haven't tried that out though, but it should be possible