Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Blender 2.90.1, Add Github Action #378

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Williangalvani
Copy link
Contributor

@Williangalvani Williangalvani commented Oct 21, 2020

From visual inspection, the updated scenes are ok.
I could use help with fixing install_blender.sh. Do we care about 2.80 and 2.81 in master?

fix #363
fix #372

Ci state can be checked in my fork.

TODO:

  • Fix install_blender.sh
  • Enable cache in Actions
  • Change action to run on PRs

Hah! I was sure this would break Travis... Oh well 🤷‍♂️

@Williangalvani Williangalvani changed the title Update for Blender 2.90.1 Update for Blender 2.90.1, Add Github Action Oct 21, 2020
@timjklein36
Copy link
Contributor

timjklein36 commented Dec 23, 2021

I was playing around with a version of install_blender.sh that could work with Blender 3.0 (based on some changes I made here: #411). It looked roughly similar to your version, however, I am thinking it would probably be beneficial to be able to utilize the version argument to choose which URL it should pull.

My first thought is that maybe just hard-coding a bunch of version URLs would be ok for now. Thoughts?

Note: additionally, it would be great if the Docker build could utilize the version number as an argument to make it easier to test different versions quickly. Something like the following:

ARG BLENDER_VERSION=2.81
ENV BLENDER_VERSION=${BLENDER_VERSION}

RUN env | grep BLENDER
$ docker build -t exporter:test .
...
Step 4/4 : RUN env | grep BLENDER
 ---> Running in ba8bdf34ca5f
BLENDER_VERSION=2.81
...
$ docker build --build-arg BLENDER_VERSION=2.91 -t exporter:test .
...
Step 4/4 : RUN env | grep BLENDER
 ---> Running in e83b6425efcf
BLENDER_VERSION=2.91
...

@fire
Copy link
Member

fire commented Dec 19, 2023

Is there interest in pulling this to Blender 4.0? I was thinking it might be worthy. Looking for support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch continuous integration from Travis CI to GitHub Actions Update the add-on for Blender 2.90
4 participants