Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough update to work with Blender 3.0 #411

Merged
merged 1 commit into from
Dec 25, 2021

Conversation

timjklein36
Copy link
Contributor

@timjklein36 timjklein36 commented Dec 23, 2021

Based on some simple testing of mine with Blender 3.0, things mostly work with the fixing of a version check that no longer works under the assumption that 2.x are the only available versions.

Aside from that version check, I updated the io_scene_godot.export method (used for testing reference exports) to be able to introspect the exporter properties successfully. This does not actually ensure that the reference exports are working correctly: it simply allows an attempted export to "work".

Note: as mentioned above one of the reference exports throws an error upon being loaded by Blender 3 (does not get to the export step) and many exported scenes differ from the current reference (obviously). So the references would need some attention from someone with experience debugging their output.

- Also, add alternative property introspection for io_scene_godot.export
  that will work with Blender 3.0
@Jason0214
Copy link
Collaborator

Thanks. Going to merge this.

This does not actually ensure that the reference exports are working correctly: it simply allows an attempted export to "work".

No worries. It is already a good start to make it usable in Blender 3.0
Once it is being used, people may going to realize when the integration/regression tests are needed, until then we don't need to worry about tests :)

@Jason0214 Jason0214 merged commit b8b883d into godotengine:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants