Add logic to upload the Godot Android library to MavenCentral #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
force-pushed
the
add_logic_to_upload_to_maven_central
branch
from
0e40ba9
to
cc4dcca
Compare
m4gr3d
force-pushed
the
add_logic_to_upload_to_maven_central
branch
from
cc4dcca
to
31163f8
Compare
m4gr3d
force-pushed
the
add_logic_to_upload_to_maven_central
branch
2 times, most recently
from
dff45af
to
135f1b9
Compare
|
@akien-mga Per our discussion, I've updated the MavenCentral logic to separate the upload and release steps. |
m4gr3d
force-pushed
the
add_logic_to_upload_to_maven_central
branch
from
135f1b9
to
ccee0ad
Compare
|
I pushed a separate commit with the same changes as I've amended into #79 for I kept it separate for now to allow proper review, then I'll squash and amend the commit log as done for |
akien-mga
force-pushed
the
add_logic_to_upload_to_maven_central
branch
from
9cb3231
to
d266a51
Compare
m4gr3d
commented
May 24, 2023
m4gr3d
commented
May 24, 2023
Add environment variables to sign the release build for the Godot Android editor and to publish the library to MavenCentral. If the environment vars are not defined, we do a simple unsigned `release_debug` build for the Android editor. Change `config.sh.in` template to use single quotes by default, to prevent expanding special characters in environment variables. To publish to MavenCentral, a new `build-android/upload-mavencentral.sh` script is added. It needs to run after the build using gradle, but we still want it to be optional and used only when making an official release, so we copy the compiled sources in the first step. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
akien-mga
force-pushed
the
add_logic_to_upload_to_maven_central
branch
from
d266a51
to
0780ea4
Compare
akien-mga
approved these changes
May 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Should be merged alongside godotengine/godot#74569
3.x version