Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the gradle build tasks to generate play store builds #74569

Merged
merged 1 commit into from
May 24, 2023
Merged

Update the gradle build tasks to generate play store builds #74569

merged 1 commit into from
May 24, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Mar 7, 2023 •
edited
Loading

Configure the gradle builds to sign and build the release version of the Godot Android Editor

Note: dependent on godotengine/godot-build-scripts#78

3.x version

@m4gr3d m4gr3d added this to the 4.1 milestone Mar 7, 2023
@m4gr3d m4gr3d requested a review from akien-mga March 7, 2023 19:38
@m4gr3d m4gr3d requested a review from a team as a code owner March 7, 2023 19:38
@m4gr3d m4gr3d mentioned this pull request Mar 7, 2023
Merged
@m4gr3d m4gr3d force-pushed the setup_play_store_builds_main branch from 82ea395 to 03f930f Compare March 7, 2023 20:59
@m4gr3d m4gr3d force-pushed the setup_play_store_builds_main branch 2 times, most recently from a60a71f to 1adc361 Compare March 8, 2023 01:08
@m4gr3d m4gr3d mentioned this pull request Mar 8, 2023
Merged
@m4gr3d m4gr3d force-pushed the setup_play_store_builds_main branch from 1adc361 to 3c50eef Compare April 3, 2023 21:19
@m4gr3d m4gr3d force-pushed the setup_play_store_builds_main branch 4 times, most recently from a1997a3 to 91982c5 Compare April 26, 2023 17:01
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 26, 2023

@akien-mga Updated this PR following our conversation.
Here also, the build generates a android_editor-release-unsigned.apk binary when the signing credentials are not provided.

@m4gr3d
Update the gradle build tasks to generate play store builds.
0d569be 
Configure the gradle builds to sign and build the release version of the Godot Android Editor
@m4gr3d m4gr3d force-pushed the setup_play_store_builds_main branch from 91982c5 to 0d569be Compare April 28, 2023 05:09
@akien-mga akien-mga merged commit 094e884 into godotengine:master May 24, 2023
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the setup_play_store_builds_main branch May 24, 2023 20:13
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:buildsystem topic:editor topic:porting
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @akien-mga @YuriSizov