Fix CMake double precision builds #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enetheru
approved these changes
Jun 1, 2025
Collaborator
enetheru
left a comment
enetheru
left a comment
There was a problem hiding this comment.
I approve these changes.
paddy-exe
approved these changes
Jun 2, 2025
Contributor
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
Makes sense in terms of how CMake works👍🏻 haven't tested the changes though
aaronfranke
approved these changes
Jun 7, 2025
Collaborator
|
Thanks! |
dsnopek
added
bug
Collaborator
|
Cherry-picked for 4.4 in PR #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double precision builds with CMake are currently broken. Since I'm contributing the fix directly I did not bother to make an issue first, but please let me know if that is required.
The
binding_generator_generate_bindingsfunction has erroneous commas after some of its arguments (i.e.,PRECISION,), but this is not correct CMake syntax; the arguments should be separated by whitespace. This causes theUSE_TEMPLATE_GET_NODE,BITS, andPRECISIONarguments to not be properly received when this function is invoked. This is partially masked for theBITSargument as there is aBITSvariable at a higher CMake scope that is used.The end result is that the
PYTHON_SCRIPTalways ends up getting populated withprecision=''anduse_template_get_node='', which makes it impossible to get a working double precision build via CMake.