Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPS Tutorial gun mesh broken #3217

Closed
MeikelLP opened this issue Feb 29, 2020 · 5 comments · Fixed by #4074
Closed

FPS Tutorial gun mesh broken #3217

MeikelLP opened this issue Feb 29, 2020 · 5 comments · Fixed by #4074
Labels

Comments

@MeikelLP
Copy link

image
image

Seems like some faces are wrong in the assets ?

using:
Godot Engine v3.2.stable.mono.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce RTX 2080/PCIe/SSE2

@Calinou Calinou added the bug label Feb 29, 2020
@Calinou
Copy link
Member

Calinou commented Feb 29, 2020

cc @TwistedTwigleg

@TwistedTwigleg
Copy link
Contributor

I opened up the project and can reproduce the issue with Windows 10, OpenGL 3 renderer.

It looks like it may be a Godot engine bug. The issue seems to be because of the Depth Draw Mode being set to Opaque Pre-Pass in the material uses for the guns (second material attached to GodotBattleBot in Player.tscn). Changing the Depth Draw Mode to Opaque Only fixes the rendering issue, but then the transparent parts of the texture, like the "sights" in the rifle model, will not be transparent.
However, it was working in Godot 3.1 just fine, and the material, textures, and 3D models have not changed since then.

Not sure what the best fix would be. Short term, the best solution is to set the Depth Draw Made to Opaque Only in the second material in GodotBattleBot. That should fix the issue, at the cost of there no longer being any transparency in the 3D gun models.
(I can make this change in #3174, if desired)

@Calinou
Copy link
Member

Calinou commented Feb 29, 2020

Opaque Pre-Pass seems to be broken in 3.2, see godotengine/godot#36669.

@TwistedTwigleg
Copy link
Contributor

Opaque Pre-Pass seems to be broken in 3.2, see godotengine/godot#36669.

Seems that is the case. I guess the solution for this bug depends on how the linked issue is handled. If it is intended functionality, then changing Depth Draw Mode to Opaque Only should be the fix, that or redoing the materials in the 3D models,

@MeikelLP
Copy link
Author

MeikelLP commented Mar 1, 2020

Thanks. I will wait for a fix :)

NathanLovato added a commit to NathanLovato/godot-docs that referenced this issue Sep 27, 2020
- Step-by-step -> UI tutorials
- Step-by-step -> splash screen tutorial
- 3D -> FPS tutorial

Closes godotengine#1412
Closes godotengine#1599
Closes godotengine#1601
Closes godotengine#1620
Closes godotengine#1667
Closes godotengine#1670
Closes godotengine#2346
Closes godotengine#2574
Closes godotengine#2875
Closes godotengine#3151
Closes godotengine#3217
Closes godotengine#3348
Closes godotengine#3751
Closes godotengine#4011
NathanLovato added a commit to NathanLovato/godot-docs that referenced this issue Sep 27, 2020
- Step-by-step -> UI tutorials
- Step-by-step -> splash screen tutorial
- 3D -> FPS tutorial

Closes godotengine#1412
Closes godotengine#1599
Closes godotengine#1601
Closes godotengine#1620
Closes godotengine#1667
Closes godotengine#1670
Closes godotengine#2346
Closes godotengine#2574
Closes godotengine#2875
Closes godotengine#3151
Closes godotengine#3217
Closes godotengine#3348
Closes godotengine#3751
Closes godotengine#4011
NathanLovato added a commit to NathanLovato/godot-docs that referenced this issue Sep 27, 2020
- Step-by-step -> UI tutorials
- Step-by-step -> splash screen tutorial
- 3D -> FPS tutorial

Closes godotengine#1412
Closes godotengine#1599
Closes godotengine#1601
Closes godotengine#1620
Closes godotengine#1667
Closes godotengine#1670
Closes godotengine#2346
Closes godotengine#2574
Closes godotengine#2875
Closes godotengine#3151
Closes godotengine#3217
Closes godotengine#3348
Closes godotengine#3751
Closes godotengine#4011
NathanLovato added a commit to NathanLovato/godot-docs that referenced this issue Sep 27, 2020
- Step-by-step -> UI tutorials
- Step-by-step -> splash screen tutorial
- 3D -> FPS tutorial

Closes godotengine#1412
Closes godotengine#1599
Closes godotengine#1601
Closes godotengine#1620
Closes godotengine#1667
Closes godotengine#1670
Closes godotengine#2346
Closes godotengine#2574
Closes godotengine#2875
Closes godotengine#3151
Closes godotengine#3217
Closes godotengine#3348
Closes godotengine#3751
Closes godotengine#4011

<!--
**Note:** Pull Requests should be made against the `master` by default.

Only make Pull Requests against other branches (e.g. `2.1`) if your changes only apply to that specific version of Godot.

All pull requests for Godot 3 should usually go into `master`.
-->
NathanLovato added a commit to NathanLovato/godot-docs that referenced this issue Sep 27, 2020
- Step-by-step -> UI tutorials
- Step-by-step -> splash screen tutorial
- 3D -> FPS tutorial

Closes godotengine#1412
Closes godotengine#1599
Closes godotengine#1601
Closes godotengine#1620
Closes godotengine#1667
Closes godotengine#1670
Closes godotengine#2346
Closes godotengine#2574
Closes godotengine#2875
Closes godotengine#3151
Closes godotengine#3217
Closes godotengine#3348
Closes godotengine#3751
Closes godotengine#4011

<!--
**Note:** Pull Requests should be made against the `master` by default.

Only make Pull Requests against other branches (e.g. `2.1`) if your changes only apply to that specific version of Godot.

All pull requests for Godot 3 should usually go into `master`.
-->
akien-mga pushed a commit to NathanLovato/godot-docs that referenced this issue Sep 28, 2020
- Step-by-step -> UI tutorials
- Step-by-step -> splash screen tutorial
- 3D -> FPS tutorial

Closes godotengine#1412
Closes godotengine#1599
Closes godotengine#1601
Closes godotengine#1620
Closes godotengine#1667
Closes godotengine#1670
Closes godotengine#2346
Closes godotengine#2574
Closes godotengine#2875
Closes godotengine#3151
Closes godotengine#3217
Closes godotengine#3348
Closes godotengine#3751
Closes godotengine#4011

<!--
**Note:** Pull Requests should be made against the `master` by default.

Only make Pull Requests against other branches (e.g. `2.1`) if your changes only apply to that specific version of Godot.

All pull requests for Godot 3 should usually go into `master`.
-->
akien-mga pushed a commit to NathanLovato/godot-docs that referenced this issue Sep 28, 2020
- Step-by-step -> UI tutorials
- Step-by-step -> splash screen tutorial
- 3D -> FPS tutorial

Closes godotengine#1412
Closes godotengine#1599
Closes godotengine#1601
Closes godotengine#1620
Closes godotengine#1667
Closes godotengine#1670
Closes godotengine#2346
Closes godotengine#2574
Closes godotengine#2875
Closes godotengine#3151
Closes godotengine#3217
Closes godotengine#3348
Closes godotengine#3751
Closes godotengine#4011

<!--
**Note:** Pull Requests should be made against the `master` by default.

Only make Pull Requests against other branches (e.g. `2.1`) if your changes only apply to that specific version of Godot.

All pull requests for Godot 3 should usually go into `master`.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants