Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to handle clicked [url] tags in RichTextLabel #5246

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 12, 2021

This closes #5245.

@Calinou Calinou force-pushed the bbcode-in-richtextlabel-url-handling branch from 132ce68 to 2fe3608 Compare September 13, 2021 00:01
@YuriSizov
Copy link
Contributor

We should do something about that table of tags, latest additions made it unusable.

image

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, either way, this looks good.

@mhilbrunner
Copy link
Member

Discussed with pycbouh, we'll merge this and we'll do those small additional things in #5261.

Thanks for this!

@mhilbrunner mhilbrunner merged commit 54644d4 into godotengine:master Sep 15, 2021
@Calinou Calinou deleted the bbcode-in-richtextlabel-url-handling branch September 16, 2021 00:20
@Calinou
Copy link
Member Author

Calinou commented Oct 15, 2021

Cherry-picked to the 3.4, 3.3 and stable branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichTextLabel url tag doesn't automatically open url when clicked
3 participants