Reorganize and update the "BBCode in RichTextLabel" article #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
force-pushed
the
bbcodes-reorganization
branch
from
6bafdce
to
850498a
Compare
|
Wait wait, I didn't actually port Calinou's changes yet |
YuriSizov
force-pushed
the
bbcodes-reorganization
branch
from
850498a
to
4f67dc3
Compare
|
Now I have 😛 |
|
Built and checked locally, looks good. Thanks for this, its a nice improvement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the bbcode reference table was unusable in its
masterversion and decided to give it a go. In the process of figuring out how to better lay out that table I've reorganized the entire first half of the article and rewrote some text to be more factual, informative and easier to read.I've also added missing information based on godotengine/godot#49587 and godotengine/godot#39113. That said, from what I've seen of the source code there are some undocumented tags and options as well, but I have no handy source of information for them. So I guess they can be improved later.
I'll try to make a dedicated 3.4 PR later. Also note, that this conflicts with #5246 and one of us would need to adjust their PR depending on which gets merged first (I'd prefer #5246 to be merged first, to be honest).
A couple of comparisons:
Reference
Current stable
Current master
This PR
Option lists
Current
This PR