Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for render mode fog_disabled #7875

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Add documentation for render mode fog_disabled #7875

merged 1 commit into from
Sep 10, 2023

Conversation

lemilonkh
Copy link
Contributor

@lemilonkh lemilonkh commented Sep 4, 2023 •
edited
Loading

Adds documentation for the render_mode fog_disabled and material setting Disable Fog added in godotengine/godot#81286.

@AThousandShips
Copy link
Member

AThousandShips commented Sep 4, 2023 •
edited
Loading

You should target master not 4.1, see here

This change hasn't been marked for cherry picking, and generally new features aren't, so it won't be relevant for 4.1 otherwise

If you need more information about the update process please see: PR Workflow - Updating your branch.

@lemilonkh lemilonkh changed the base branch from 4.1 to master September 4, 2023 10:06
@AThousandShips
Copy link
Member

You need to drop the two first commits you have, they are not part of this

@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Sep 4, 2023
@lemilonkh lemilonkh mentioned this pull request Sep 4, 2023
Merged
clayjohn
clayjohn approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge once the related PR is merged

@AThousandShips
Copy link
Member

Could you please squash your commits into one, see here.

@lemilonkh
Copy link
Contributor Author

Done 👍

@AThousandShips AThousandShips added this to the 4.2 milestone Sep 6, 2023
@lemilonkh
Copy link
Contributor Author

godotengine/godot#81286 has been merged, so this can probably be merged as well

@mhilbrunner mhilbrunner merged commit 4cff84e into godotengine:master Sep 10, 2023
@mhilbrunner
Copy link
Member

Thanks for contributing to Godot's docs, and congrats on your first merged PR to this repository!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lemilonkh @AThousandShips @mhilbrunner @clayjohn