Implement render mode fog_disabled and BaseMaterial3D setting Disable Fog
#81286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The flag needs to be documented, see the CI errors |
lemilonkh
force-pushed
the
unshaded-materials-ignore-fog
branch
from
e1e2180
to
0341df4
Compare
|
I'm not quite sure what causes the failure in this pipeline: https://github.com/godotengine/godot/actions/runs/6067098408/job/16458879823?pr=81286 |
|
Unrelated to this PR, sporadic error |
servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl
Outdated
Show resolved
Hide resolved
servers/rendering/renderer_rd/shaders/forward_mobile/scene_forward_mobile.glsl
Outdated
Show resolved
Hide resolved
lemilonkh
force-pushed
the
unshaded-materials-ignore-fog
branch
from
edf0262
to
6b325e3
Compare
lemilonkh
changed the title
lemilonkh
changed the title
clayjohn
approved these changes
Sep 5, 2023
akien-mga
changed the title
fog_disabled and BaseMaterial3D setting Disable Fog
|
Could you please squash your commits into one? Make sure that the final commit has a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing. |
lemilonkh
force-pushed
the
unshaded-materials-ignore-fog
branch
from
6b325e3
to
45a33cc
Compare
|
Done ✨ |
|
Thanks, and congrats on your first merged Godot PR! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #56374 (and its duplicates like #69268).
A new render mode called
fog_disabledis added. It can be used in spatial shaders (usingrender_mode fog_disabled) and fromStandardMaterial3Dusing the new toggleDisable Fogfound in theShadingsection.This works for the Forward+, Mobile and Compatibility rendering backends.
Documentation for the new render mode and material setting has been added in this PR: godotengine/godot-docs#7875
Screenshots
Minimal reproduction project
The minimal reproduction project from #56374 has been modified to include a DirectionalLight3D (without which the volumetric fog wouldn't render anymore), and the new
disable_fogproperty has been enabled on the unshaded additively blended mesh. I've also enabled the depth-based fog to test the effect on the Mobile and Compatibility render backends as they don't support volumetric fog, and added a cube with a shader material usingrender_mode unshaded;to demonstrate this working as well.It can be downloaded here:
Fog_Volume_Additive.zip