-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visual shader node interface explanation #8459
Add visual shader node interface explanation #8459
Conversation
Please convert the image to the |
be1207e
to
a8cd252
Compare
@AThousandShips done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I wonder how maintainable the example screenshots are, as we struggle to keep screenshots updated with Godot updates.
So we should consider how many of these we would expect to be adding for this, how often we expect them to change, and how much value they add. Happy to hear y'alls thoughts :)
@mhilbrunner I agree that the screenshot represent UI that can change over time. However, its just an example and not a direct fact. |
If it's just these screenshots I would consider this maintainable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this in the original review, apologies. But the outline for the vs_node image needs to be a different color. We use a specific shade of yellow (hex color is fffb44, fffb44ff if you're using something with transparency) so color blind people don't have issues reading the documentation.
Added port types
Thank you. I read the instructions in: https://docs.godotengine.org/en/stable/contributing/documentation/docs_image_guidelines.html I should have read that before submitting. My mistake. |
a8cd252
to
ee9e10e
Compare
I would perhaps hold off this PR from this for a while longer as there's a redesign coming in terms of both UX and Color Design: godotengine/godot#85017 |
I get it, but the work that's done for this PR is already done. I don't see holding off on this PR as giving us less work in the future. |
Thanks! |
Added visual shader port types, which greatly increases clarity for newbies.