Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line index color of empty lines should be white #1015

Closed
Tracked by #40488
MaaaxiKing opened this issue Jun 5, 2020 · 7 comments
Closed
Tracked by #40488

Line index color of empty lines should be white #1015

MaaaxiKing opened this issue Jun 5, 2020 · 7 comments

Comments

@MaaaxiKing
Copy link

MaaaxiKing commented Jun 5, 2020

Describe the project you are working on:

Describe the problem or limitation you are having in your project:
Empty lines aren't unsafe lines but they aren't real safe lines, they're just empty. The line index color is sometimes green (safe) and sometimes gray (unsafe). I couldn't find what it depends on.
Describe the feature / enhancement and how it helps to overcome the problem or limitation:
Empty lines/ lines with spaces/ lines with indentations should have the line index color white.
Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:
1 extends Node
2
3 var test
If this enhancement will not be used often, can it be worked around with a few lines of script?:
No.
Is there a reason why this should be core and not an add-on in the asset library?:
I don't have experience with add-ons.

@MaaaxiKing MaaaxiKing changed the title Line color of empty lines white Line index color of empty lines should be white Jun 5, 2020
@dalexeev
Copy link
Member

dalexeev commented Jun 5, 2020

Empty lines aren't unsafe lines but they aren't really safe lines

In fact, empty lines are the safest lines. 😆
Three colors is too much. Gray color indicates possible type errors. If there are no such errors, then all lines should be green.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 5, 2020

tbh this sounds more like a bug.

@MaaaxiKing
Copy link
Author

MaaaxiKing commented Jun 6, 2020

@KoBeWi Yes, I also think it's a bug but I made a proposal because I don't want this bug to be fixed and then the color would be changed anyway to another (my suggestion: white) if this proposal will be accepted.

@dalexeev
Copy link
Member

See also: godotengine/godot#20418.

@Calinou
Copy link
Member

Calinou commented Sep 13, 2020

Having three different line number colors might start looking like Christmas 🙂

I think it'd be better to always mark blank/comment lines as safe instead.

@MewPurPur
Copy link

These are already marked safe in 4.0

@Calinou
Copy link
Member

Calinou commented Feb 16, 2023

These are already marked safe in 4.0

Indeed, this is implemented as of 4.0.rc1 (albeit differently from what's proposed in OP, but the intent is similar):

image

@Calinou Calinou closed this as completed Feb 16, 2023
@Calinou Calinou added this to the 4.0 milestone Feb 16, 2023
@Calinou Calinou moved this to Implemented in Godot Proposal Metaverse Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Implemented
Development

No branches or pull requests

5 participants