Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to copy parameters path from shaders and animation trees #106

Closed
IllusiveS opened this issue Sep 26, 2019 · 4 comments · Fixed by godotengine/godot#39404
Closed

Comments

@IllusiveS
Copy link

Describe the project you are working on:
Currently i am developing a few small game-jam like projects

Describe how this feature / enhancement will help your project:
Not having to transcribe the values of paths will save some time and help avoid bugs when mistyping

Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:
I hover mouse over the property with shader parameter
image
and now i want to press or do something that will save property path to clipboard so that i can easily copy it into the script

Describe implementation detail for your proposal (in code), if possible:
No clue, if someone could direct me somewhere i could do it myself probably, but right now i don't know much about godot to propose code

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Not that i know of, if it is, i would love to make a plugin for it then

Is there a reason why this should be core and not an add-on in the asset library?:
Do not know if it is possible to do that, it might be because some inspector fields can tell the difference between right and left click

@clayjohn
Copy link
Member

You don't need to the full property path to set shader uniforms. You just need the name of the uniform itself, no need to hover even.

In GDScript

myMaterial.set_shader_param("Slowmo", slowmo_value)

@IllusiveS
Copy link
Author

Perhaps shader was not the best example, but parameter copying from animation tree would be useful

@rcorre
Copy link

rcorre commented Jun 8, 2020

I'm working on this now, finally got annoyed after enough typos transcribing AnimationTree paths 😁

@Calinou
Copy link
Member

Calinou commented Jun 22, 2021

Duplicate of #655 (both use EditorInspector).

@Calinou Calinou closed this as completed Jun 22, 2021
rcorre added a commit to rcorre/godot that referenced this issue Aug 23, 2021
Resolves godotengine/godot-proposals#106.

Adds the following property menu options with default bindings:

- Copy Property (ctrl+c)
- Paste Property (ctrl+v)
- Copy Property Path (ctrl+shift+c)

If you hover over a property label in the inspector dock, you can copy
either the property value or the property path to the system clipboard
using the shortcuts above This is especially useful for the
`AnimationTree`, where code might reference properties like
"parameters/state/aim/move/blend_position".

One issue is that if you click a property, then click on the node you
currently have selected in the node tree, then press ctrl+shift+c, it
will still copy the selected property path rather than the node path. If
you click on a different node in the nodetree, however, ctrl+shift+c
will return to copying the nodepath.

The property value copy/paste was implemented by @KoBeWi at godotengine#39398 and
merged into this PR due to their similarity.
rcorre added a commit to rcorre/godot that referenced this issue Dec 27, 2021
Resolves godotengine/godot-proposals#106.

Adds the following property menu options with default bindings:

- Copy Property (ctrl+c)
- Paste Property (ctrl+v)
- Copy Property Path (ctrl+shift+c)

If you hover over a property label in the inspector dock, you can copy
either the property value or the property path to the system clipboard
using the shortcuts above This is especially useful for the
`AnimationTree`, where code might reference properties like
"parameters/state/aim/move/blend_position".

One issue is that if you click a property, then click on the node you
currently have selected in the node tree, then press ctrl+shift+c, it
will still copy the selected property path rather than the node path. If
you click on a different node in the nodetree, however, ctrl+shift+c
will return to copying the nodepath.

The property value copy/paste was implemented by KoBeWi at godotengine#39398 and
merged into this PR due to their similarity.

Backport of 0205fff from master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants