Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make smoothstep and step nodes more user friendly #5090

Closed
QbieShay opened this issue Aug 6, 2022 · 0 comments · Fixed by godotengine/godot#78547
Closed

Make smoothstep and step nodes more user friendly #5090

QbieShay opened this issue Aug 6, 2022 · 0 comments · Fixed by godotengine/godot#78547

Comments

@QbieShay
Copy link

QbieShay commented Aug 6, 2022

Describe the project you are working on

VFX

Describe the problem or limitation you are having in your project

When creating a smoothstep and step node, visual shader auto connects to the first port, which is "edge", which is almost never the case in the flow of development of VS: normally you drag out the pin from the value first and add the edges later. At least for me, I haven't dragged the edge first so far, it's always been the value.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

There's two options to solve this:

  1. change the order of parameters in the shader nodes (compat-breaking)
  2. give nodes an option to specify the default port for connection (not compat breaking)

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

add a get_default_port overrideable function

If this enhancement will not be used often, can it be worked around with a few lines of script?

no

Is there a reason why this should be core and not an add-on in the asset library?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants