Make the dragging connections more user-friendly in visual shaders #78547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
vs_drag_enhancement
branch
2 times, most recently
from
f80142a
to
c2131c3
Compare
QbieShay
approved these changes
Jun 22, 2023
|
The method should probably take a "type" parameter, so that it can return different values depending on the data type of the connection. Since not all nodes have the same data types for all input ports. |
|
@Chaosus What do you think about the suggestion above? |
|
Sounds reasonable, I take a look to implement this... PS: Done |
Chaosus
force-pushed
the
vs_drag_enhancement
branch
from
c2131c3
to
88001ab
Compare
|
Hey! testted the smoothstep connection, thanks a lot for doing the groundwork for this improvement! I don't think that the type is working? maybe i misunderstood how it works |
It has meaning only for |
YuriSizov
approved these changes
Jul 17, 2023
Chaosus
force-pushed
the
vs_drag_enhancement
branch
from
88001ab
to
0110113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
get_default_input_portfunction toVisualShaderNode, so now nodes can be connected to specified port by default when the new node created from dragging from output ports. Implemented the overrides forsmoothstep/stepnodes. Closes godotengine/godot-proposals#5090