Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D bones gizmo manipulators for skeletons #584

Closed
2plus2makes5 opened this issue Mar 14, 2020 · 8 comments
Closed

Add 3D bones gizmo manipulators for skeletons #584

2plus2makes5 opened this issue Mar 14, 2020 · 8 comments

Comments

@2plus2makes5
Copy link

Describe the project you are working on:
2.5d beat'em up

Describe the problem or limitation you are having in your project:
The same mesh or animation can make different impressions in different situations, if i want to simply tweak an animation i have to either edit raw numbers in the editor or go to blender, modify, re-export, return to godot and re-import again, hoping i don't have to tweak again.
Also related: skeletons lack the last bones.

Describe the feature / enhancement and how it helps to overcome the problem or limitation:
A simple default gizmo to manipulate bones, we should be able to make little adjustment without having to go to blender, re-export and re-import again, also it would be extremely convenient to make animations directly in Godot.

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:
At each bone would be attached the default gizmo to let us move them.

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Everyone working with 3d skeletons would use this.

Is there a reason why this should be core and not an add-on in the asset library?:
In my opinion it's an essential feature that should be accessed by everyone, it shouldn't be a simple add-on.

@Calinou
Copy link
Member

Calinou commented Mar 15, 2020

I believe this is implemented by godotengine/godot#36409, but it hasn't been merged yet.

Edit: godotengine/godot#36409 doesn't add manipulation gizmos as confirmed by #584 (comment).

@2plus2makes5
Copy link
Author

I believe this is implemented by godotengine/godot#36409, but it hasn't been merged yet.

I didn't know it, thanks! :)
I hope it will be merged soon.

@fire
Copy link
Member

fire commented Mar 24, 2020

Sorry, my pr only handles manually changing the properties of the bones.

I've been using this issue to track the design. https://github.com/godotengine/godot/issues/30542.

[I can't read. Removed some text.]

@Calinou Calinou changed the title 3d Bones gizmo manipulators Add 3D bones gizmo manipulators Sep 28, 2020
@Calinou Calinou changed the title Add 3D bones gizmo manipulators Add 3D bones gizmo manipulators for skeletons Oct 8, 2020
@Shadowblitz16
Copy link

Please add this!
Making animations in blender is very difficult and doesn't allow us to animate all the properties in the godot engine.
Blender is known for its sadistic UI, and TBH if Godot supports rigging and animating in 2d it should in 3d too.

@GeorgeS2019
Copy link

GeorgeS2019 commented Apr 22, 2021

@Shadowblitz16 @2plus2makes5 check this and could be the first step towards being part of 3D character workflow from Blender to Godot.

@master172
Copy link

well in twitter i recently found out that it has been merged it wan not by juan or the official godot twitter but it sounded like the original creator of the 3d bone gizmo manipulator had tweeted it saying it is merged

@Zireael07
Copy link

@master172: Yes, the skeleton gizmo PR was merged recently.

@Calinou
Copy link
Member

Calinou commented Oct 8, 2021

This was implemented by godotengine/godot#45699, closing.

Since the above PR relies on subgizmos that break compatibility with existing editor plugins, this can't be backported to 3.x.

@Calinou Calinou closed this as completed Oct 8, 2021
@Calinou Calinou modified the milestones: 4.x, 4.0 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants