Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict onEnterRules for controlling indentation #344

Merged
merged 4 commits into from
May 6, 2022

Conversation

wachtel1
Copy link
Contributor

@wachtel1 wachtel1 commented Apr 7, 2022

Bugsquad edit: This closes #337.

@Calinou Calinou added the bug label Apr 7, 2022
@Calinou
Copy link
Member

Calinou commented Apr 7, 2022

Just to make sure, is this good to merge now?

@wachtel1
Copy link
Contributor Author

@Calinou Please see the behavior on the gif below.
337_fix
Moving the line after the if statement down works correctly.
Pasting after the if statement works correctly.

Adding indentation by just pressing Enter works as before.
I also tested other statements that have indentation rules.

The problem I'm having with this is that I can't explain why it fixes the issue, so if someone is willing to test this config as well, as I have only one environment to test on, it would be better.

@DaelonSuzuka
Copy link
Collaborator

This is a big improvement over the previous behavior.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou changed the title added strict onEnterRules for controlling indentation Add strict onEnterRules for controlling indentation May 6, 2022
@Calinou Calinou merged commit 1d76541 into godotengine:master May 6, 2022
@wachtel1 wachtel1 deleted the indentation-rules branch May 9, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overaggressive formatting when adding new lines after an if statement
3 participants