Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various syntax highlighting problems #441

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

DaelonSuzuka
Copy link
Collaborator

This fixes a number of minor syntax highlighting problems I've identified.

Incorrect quote matching on $ operator

image

Multiple statements on one line using ; (semicolon)

This one's a bit wierd:

v1.3.1:

image

current master:

image

This PR:

image

Other problems

I've seen some problems with Godot 4 syntax, too, but unfortunately I wasn't smart enough to make notes on all of them. I'm going to do some work in Godot 4 this weekend, and if I see anything weird I'll try to get it added to this PR.

  • set/get: I remember seeing something wrong with these, maybe related to line-continuations?
  • ???

@DaelonSuzuka DaelonSuzuka added this to the 1.4.0 milestone Dec 24, 2022
@Calinou
Copy link
Member

Calinou commented Feb 9, 2023

Is this good to merge now? Sorry for the delay 🙂

@DaelonSuzuka
Copy link
Collaborator Author

DaelonSuzuka commented Feb 9, 2023

I just put in a fix for #449:

Before:
image

After:
image

good to merge now?

@Calinou Yeah, this is ready.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 3ce2563 into godotengine:master Mar 14, 2023
@DaelonSuzuka DaelonSuzuka deleted the syntax_fixes branch March 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single-line scopes are confused for type annotations
2 participants