Launching the editor opens a new custom terminal #561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per feedback from @KoBeWi, this PR moves the process started by
Open Workspace with Godot Editor
back to a terminal (instead of a headless child process).This time the terminal is implemented correctly, with a name + icon, and doesn't have a lingering prompt that you really shouldn't use. It also prints that the editor was stopped and what the exit code was.
Notes:
Open Workspace with Godot Editor
again will close any existing windows and start a new one. I don't see a reason to open the same workspace multiple times.godotTools.editor.verbose
: Whether to launch the Godot Editor with the --verbose flaggodotTools.editor.reveal
: Whether to reveal the terminal when launching the Godot Editor