Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LSP connection attempts not resetting #638

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

DaelonSuzuka
Copy link
Collaborator

Should fix #636.

The internal count of connection attempts was incorrectly not being reset when a connection is actually established. This caused the connection retry to fail after several successful reconnections.

@DaelonSuzuka DaelonSuzuka merged commit 24e72ec into godotengine:master Apr 6, 2024
4 checks passed
@DaelonSuzuka DaelonSuzuka deleted the fix-lsp-retry-count branch April 24, 2024 21:59
@Calinou Calinou added the bug label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset connection attempts on successfull connect to a GDScript language server.
2 participants