Skip to content

Commit

Permalink
Merge pull request #88245 from shana/simplify-mono-support-detection
Browse files Browse the repository at this point in the history
C#: Let platforms signal if they support the mono module or not
  • Loading branch information
akien-mga committed Feb 18, 2024
2 parents 0f0515a + 21e524a commit 033821c
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
10 changes: 3 additions & 7 deletions modules/mono/config.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
# Prior to .NET Core, we supported these: ["windows", "macos", "linuxbsd", "android", "web", "ios"]
# Eventually support for each them should be added back.
supported_platforms = ["windows", "macos", "linuxbsd", "android", "ios"]


def can_build(env, platform):
if env["arch"].startswith("rv"):
return False
Expand All @@ -14,9 +9,10 @@ def can_build(env, platform):


def configure(env):
platform = env["platform"]
# Check if the platform has marked mono as supported.
supported = env.get("supported", [])

if platform not in supported_platforms:
if not "mono" in supported:
raise RuntimeError("This module does not currently support building for this platform")

env.add_module_version_string("mono")
Expand Down
1 change: 1 addition & 0 deletions platform/android/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def get_flags():
return [
("arch", "arm64"), # Default for convenience.
("target", "template_debug"),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/ios/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def get_flags():
("arch", "arm64"), # Default for convenience.
("target", "template_debug"),
("use_volk", False),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/linuxbsd/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def get_doc_path():
def get_flags():
return [
("arch", detect_arch()),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/macos/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ def get_flags():
return [
("arch", detect_arch()),
("use_volk", False),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/windows/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ def get_flags():

return [
("arch", arch),
("supported", ["mono"]),
]


Expand Down

0 comments on commit 033821c

Please sign in to comment.