Merge pull request #93815 from HolonProduction/comletion-variant-lookup

Autocompletion: Don't use `in` operator to decide over variant lookup
godotengine · Jul 8, 2024 · 8829670 · 8829670
2 parents e1a145b + 70488d4
commit 8829670
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/modules/gdscript/gdscript_editor.cpp b/modules/gdscript/gdscript_editor.cpp
@@ -1959,11 +1959,14 @@ static bool _guess_expression_type(GDScriptParser::CompletionContext &p_context,
  break;
  }
 
- if (base.value.in(index.value)) {
- Variant value = base.value.get(index.value);
- r_type = _type_from_variant(value, p_context);
- found = true;
- break;
+ {
+ bool valid;
+ Variant value = base.value.get(index.value, &valid);
+ if (valid) {
+ r_type = _type_from_variant(value, p_context);
+ found = true;
+ break;
+ }
  }
 
  // Look if it is a dictionary node.