Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion: Don't use in operator to decide over variant lookup #93815

Merged

Conversation

HolonProduction
Copy link
Member

Fixes #93799

The in operator is not directly linked to whether get will have success. E.g. for arrays the in operator searches for values while get works with an index.

Instead we can just try to get and only use the result if successful.

@HolonProduction HolonProduction requested a review from a team as a code owner July 1, 2024 13:29
Copy link
Contributor

@anniryynanen anniryynanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced the issue and confirm that this PR fixes it. The code looks good, I don't think it's likely to break anything.

@akien-mga akien-mga merged commit 8829670 into godotengine:master Jul 8, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@HolonProduction HolonProduction deleted the comletion-variant-lookup branch October 5, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error spam while typing legal and functional code
4 participants