Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script editor crashing when performing autocomplete #10654

Closed
Calinou opened this issue Aug 26, 2017 · 1 comment · Fixed by #10671
Closed

Script editor crashing when performing autocomplete #10654

Calinou opened this issue Aug 26, 2017 · 1 comment · Fixed by #10671
Labels
bug topic:editor
Milestone
3.0

Comments

@Calinou
Copy link
Member

Calinou commented Aug 26, 2017 •
edited
Loading

Operating system or device, Godot version, GPU Model and driver (if graphics related): Windows 10, Godot Git dd7145b compiled with MSVC 2017

Issue description:
The script editor always crashes when performing autocomplete, which is usually done by editing characters in a script.

Steps to reproduce: In the example project (see below), edit the autoload/console.gd script at line 55. Specifically, try editing the string that is passed to the append_bbcode() function there. Editing the script in other places (such as comments, or variable declarations) does not seem to cause a crash.

Stack trace:

script_editor_backtrace

Link to minimal example project: godot-console.zip
@hpvb
Copy link
Member

hpvb commented Aug 26, 2017

I found the issue, making a PR.

hpvb added a commit to hpvb/godot that referenced this issue Aug 26, 2017
@hpvb
Add two missing Null checks
3e25cf9 
These Null checks were removed in godotengine#10581 but actually changed the
logic of the functions in this case.

This fixes godotengine#10654
@hpvb hpvb mentioned this issue Aug 26, 2017
Merged
@akien-mga akien-mga added this to the 3.0 milestone Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Add two missing Null checks hpvb/godot
3 participants
@Calinou @hpvb @akien-mga