Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip in Project Manager gives ERROR: Condition "!windows.has(p_window)" is true. #39199

Closed
Anutrix opened this issue May 31, 2020 · 6 comments · Fixed by #39888
Closed

Tooltip in Project Manager gives ERROR: Condition "!windows.has(p_window)" is true. #39199

Anutrix opened this issue May 31, 2020 · 6 comments · Fixed by #39888
Labels
bug confirmed regression topic:gui
Milestone
4.0

Comments

@Anutrix
Copy link
Contributor

Anutrix commented May 31, 2020 •
edited
Loading

Godot version:
master a8787d1

OS/device including version:
Windows 10 1909

Issue description:
Any tooltip in Project Manager gives:

ERROR: Condition "!windows.has(p_window)" is true.
   at: window_resize (drivers\vulkan\vulkan_context.cpp:723)

every time that it is generated.

Steps to reproduce:
1 . Open Godot.
2A. Hover over "Show in File Manager" Button of any project.
OR
2B. Hover over the search bar.

Minimal reproduction project:
NA
@ThakeeNathees
Copy link
Contributor

I can conform that on windows 10, display server issue : #37734(tracker) is this only in windows ??

@bruce965
Copy link
Contributor

bruce965 commented Jun 2, 2020

030a262 on Linux Mint 19.3 works fine.

@Anutrix
Copy link
Contributor Author

Anutrix commented Jun 3, 2020

Seems like a Windows-specific issue.

@ThakeeNathees
Copy link
Contributor

Here is a gif
tooltipbug

pouleyKetchoupp added a commit to nekomatata/godot that referenced this issue Jun 27, 2020
@pouleyKetchoupp
Fix errors when creating windows on Windows
1043576 
Detecting the case where WM_SIZE is received during the window creation.
There's no need to call window_resize on the Vulkan context.

Also creating a WindowData entry early enough to avoid storing a
separate WindowData wrongly associated to INVALID_WINDOW_ID.

Fixes godotengine#39199
@pouleyKetchoupp pouleyKetchoupp mentioned this issue Jun 27, 2020
Merged
@akien-mga akien-mga added this to the 4.0 milestone Jun 27, 2020
@ThakeeNathees
Copy link
Contributor

ThakeeNathees commented Aug 14, 2020 •
edited
Loading

the error message (!windows.has(p_window)) has gone now but still the toolitp is blinking in windows (as mentioned above: #39199 (comment))

@pouleyKetchoupp

@pouleyKetchoupp
Copy link
Contributor

pouleyKetchoupp commented Aug 14, 2020 •
edited
Loading

@ThakeeNathees That looks like a separate issue.
On Windows: In the scene tree and script list, tooltips target the wrong item and they keep blinking. They work correctly in the inspector.
On Linux & MacOS: From what I've just tested on master, tooltips are not displayed at all in the scene tree or script list.

Edit: Just opened #41261 for the blinking issue & #41262 for the missing tooltips.

MarcusElg pushed a commit to MarcusElg/godot that referenced this issue Oct 19, 2020
@pouleyKetchoupp @MarcusElg
Fix errors when creating windows on Windows
40dede1 
Detecting the case where WM_SIZE is received during the window creation.
There's no need to call window_resize on the Vulkan context.

Also creating a WindowData entry early enough to avoid storing a
separate WindowData wrongly associated to INVALID_WINDOW_ID.

Fixes godotengine#39199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed regression topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix errors when creating windows on Windows nekomatata/godot
6 participants
@Calinou @bruce965 @pouleyKetchoupp @akien-mga @Anutrix @ThakeeNathees