Particles and Particles2D signal when finished

[AlexHolly]

http://godotengine.org/qa/883/how-to-remove-a-particle2d

[bojidar-bg]

You want a signal or just auto-free?

[AlexHolly]

Depends on the use case I think.

1. Someone who wants to re-use that Particle Node doesn't want auto-free.
2. In my case I need just auto-free.

A boolean would be nice but what is with someone who wants to play a sound on end or play another Particle?

[bojidar-bg]

Well, with a "emission ended" signal, we can just particles.connect("emission_ended", particles, "queue_free") or even particles.connect("emission_ended", player, "queue_free"), so it is way more useful actually (note that you can connect those through the Node panel as well).

[bojidar-bg]

Reopening, as the above PR was reverted when GPU particles were added.

[coppolaemilio]

I was about to ask about this issue. Is there a way to autofree them? I have a one_shot particle eaverytime a bullet hits a wall, and I'm worried that they will never get free if I don't do it manually

[KoBeWi]

A workaround is using a Timer.

[MatthewDLudwig]

Why was this reverted with the addition of GPU particles?

Hmm upon looking around at the code, I guess my real question is what the final status of the original issue is. To me it seems:

Particles2D runs on GPU and so I didn't dive too deep there, doesn't look like it'd be able to detect the end but I'm not confident on that.
CPUParticles2D resets the active flag to false if looping isn't true which I think is fine instead of signals, though signals would be cleaner.

I didn't look into the 3D nodes, but I assume the situation is the same. Can anyone confirm this, and maybe we can close out the issue with an official solution for detecting particle emission end for the various emitters.

[KoBeWi]

Because the particle system was rewritten.

Also this should probably go to godotengine/godot-proposals#815

[MatthewDLudwig]

Thanks for the link, seems it's already been suggested. If anyone finds themselves here when looking for the solution, you can show your support for this being added to 4.0 at godotengine/godot-proposals#815 (comment)

[KoBeWi]

So I guess this can be closed in favor of the proposal.