Add emission_finished signal to Particles2D #7887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Also remove some Particles2D::testee method, which was unused) Resolves godotengine#3963
27thLiz
approved these changes
Feb 25, 2017
|
my lord this is awesome, can we please get this in 3.0 too? can't find the signals currently. was about to make an issue about particle2d signals |
|
Well, it is removed by reduz in 95560e0, when he added GPU particles. Guess someone should redo it :) |
|
really wish particle attractor 2d node could make a return someday as well. loved the suction (black hole) effect you could create with that node. however, the performance with the new particle system is absolutely way better so not complaining there. just trying to think of more ways to make it even better |
|
@girng you can do something similar with a custom particles shader.. not that it is as simple as before.. |
|
@bojidar-bg thanks, will look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Also remove some Particles2D::testee method, which was unused)
Closes #3963