Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Edit - mouse wheel should zoom by default and not scroll #41538

Closed
Tracked by #19806
EricEzaM opened this issue Aug 26, 2020 · 4 comments
Closed
Tracked by #19806

Graph Edit - mouse wheel should zoom by default and not scroll #41538

EricEzaM opened this issue Aug 26, 2020 · 4 comments

Comments

@EricEzaM
Copy link
Contributor

EricEzaM commented Aug 26, 2020

Godot version:
3.2.2 and 4.0

OS/device including version:
Any

Issue description:
I think the graph edit should zoom by default rather than scroll up and down, like Blenders compositing view. It feels a lot more natural imo. Also current there is no mouse wheel shortcut to zoom... which feels really bad. I usually like navigating in node-based workflows (like UE4 bluprints) by zooming in and out. Only having the on-screen buttons to do this feels clunky.

The code is there to do this... I have no idea why it was commented out. Enabling it makes it work perfectly fine. This comment was made by reduz in 34c022a over 4 and a half years ago. I think it works fine, however it could feel better once combined with adjustments made possible by PR #38261.

godot/scene/gui/graph_edit.cpp

Lines 1010 to 1018 in a609b30

if (b->get_button_index() == BUTTON_WHEEL_UP && b->is_pressed()) {
//too difficult to get right
//set_zoom(zoom*ZOOM_SCALE);
}
if (b->get_button_index() == BUTTON_WHEEL_DOWN && b->is_pressed()) {
//too difficult to get right
//set_zoom(zoom/ZOOM_SCALE);
}

@bruvzg bruvzg added this to the 4.0 milestone Aug 26, 2020
@EricEzaM
Copy link
Contributor Author

Also I have tested it using set_zoom_custom(<zoom>, b->get_position()) so it zooms to your mouse position, and it feels really good.

@fire
Copy link
Member

fire commented Aug 26, 2020

The original reason was that zooming makes scaling 2d look bad, but antialiasing is off in master so it doesn't show.

That was the original reason for the disable.

Edited: See also. #40866

@Chaosus
Copy link
Member

Chaosus commented Sep 5, 2020

Duplicate of #5214, however since it targets only Visual Shader I will close the old one

@Calinou
Copy link
Member

Calinou commented Feb 25, 2021

Closing in favor of godotengine/godot-proposals#2352, as feature proposals are now tracked on the Godot proposals repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants