-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make zoom limits and step adjustable in GraphEdit
#38261
Make zoom limits and step adjustable in GraphEdit
#38261
Conversation
1fb06be
to
4d3523a
Compare
3e9ea29
to
2a776cd
Compare
Not sure the linear zoom property is necessary, I'm not sure anyone's ever asked for this and if someone really does need this isn't it possible for them to implement it themselves? |
I'm fine with cutting it out of this PR. As for implementing it on the user side, I don't think it would be trivial, no. |
Well if all the zoom properties are exposed, couldn't someone make a script that extends GraphEdit and in |
2a776cd
to
c78e6e3
Compare
GraphEdit
PR amended. The linear zoom option was removed as not that desired. Code was rebased against the most recent master, some code style changes were applied as well as some other adjustments to code to better fit the overall state of our codebase (now that I know it better). Edit: Push below to make sure that the label has a consistent look. |
c78e6e3
to
0a82a66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it, but the code looks good to me.
Thanks! |
Closes #38249.
This also adds an optional label to the toolbar of the GraphEdit to display current zoom level (in percent).
Note: Earlier version of this PR featured a linear zoom option that was removed
2021-06-16_16-38-33.mp4
New settings are neatly grouped. I've also gone ahead and grouped connection lines related settings.