Allow higher and lower maximum zoom values in GraphEdit #49437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Low zoom values result in unreadable text, but it can still be useful for previewing purposes. Eventually, characters could be replaced by rectangles at very low zoom levels to improve the visual appearance.
Calinou
added
cherrypick:3.3
cherrypick:3.x
|
I still have a PR that makes those values customizable #38261 |
|
Also #47986... |
|
Well my PR is over a year old, I think. So if any of you would like to expose min, max and step for the configuration in yours, be my guest :) |
CertifiedRice
suggested changes
Jun 9, 2021
| // but this is still useful for previewing purposes. | ||
| #define MIN_ZOOM (1 / Math::pow(ZOOM_SCALE, 8)) | ||
|
|
||
| // Allow zooming 4 times from the default zoom level. |
There was a problem hiding this comment.
Might as well add only 1 comment saying which part allows zooming how many times? That might help a bit.
There was a problem hiding this comment.
@CertifiedRice I think it's obvious enough from the number in the comment matching the Math::pow() exponent.
akien-mga
approved these changes
Jun 15, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low zoom values result in unreadable text, but it can still be useful for previewing purposes.
Eventually, characters could be replaced by rectangles at very low zoom levels to improve the visual appearance.