Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GraphEdit Zoom Settings #41664

Closed

Conversation

Rubonnek
Copy link
Member

@Rubonnek Rubonnek commented Sep 1, 2020

I was playing around with LittleMouseGames/whiskers dialogue editor by @finchMFG when I noticed that the GraphEdit zoom settings are locked in as macros and not configurable.

This PR fixes that by allowing users to set the maximum and minimum zoom options as well as the zoom scale that configures the intensity the plus/minus zoom buttons act upon.

What I feel is missing is the ability to zoom in and out by holding Ctrl + Button Wheel Up and Down. It looks like the code intended to provide this but it was never finished -- I'll submit a separate PR for that later.

@YuriSizov
Copy link
Contributor

YuriSizov commented Sep 1, 2020

Isn't this the same as #38261? There is also already a PR for the scroll wheel.

Edit, sorry, not a PR but a recent open discussion #41538

@Rubonnek
Copy link
Member Author

Rubonnek commented Sep 1, 2020

Welp, you are right. I didn't even check if there were open PRs for this.

I'll close this and the 3.2 version.

Thanks for letting me know!

@Rubonnek Rubonnek closed this Sep 1, 2020
@Rubonnek Rubonnek deleted the expose-graphedit-zoom-settings branch September 1, 2020 12:10
@akien-mga akien-mga added this to the 4.0 milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants