Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bullet] [Needs Bullet Update] Crashing asserts in debug when using Bullet Physics with CCD enabled #43868

Closed
Tracked by #45022
pouleyKetchoupp opened this issue Nov 25, 2020 · 4 comments · Fixed by #48299

Comments

@pouleyKetchoupp
Copy link
Contributor

Godot version:
Master 50db0e6

OS/device including version:
Windows 10

Issue description:
Bullet raises some asserts that cause crashes in some scenarios when using continuous collision with 3D rigid bodies.

This issue only happens on Godot 4.0, in debug or release_debug configuration, because these asserts have been enabled with PR #34236.

It's actually happening even when continuous collision is disabled at the moment, until PR #43801 is merged (it fixes Bullet bodies using continuous collision when they shouldn't).

More details in #42643 (comment).

Steps to reproduce:

  • Open MRP
  • Start game
  • Wait for a moment for rigid bodies to be created and observe assert and crash

Minimal reproduction project:
bullet-ccd-4.0.zip

@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Nov 25, 2020
@pouleyKetchoupp pouleyKetchoupp changed the title Crashing asserts in debug when using Bullet Physics with CCD enabled [Bullet] Crashing asserts in debug when using Bullet Physics with CCD enabled Jan 14, 2021
@qarmin
Copy link
Contributor

qarmin commented Feb 25, 2021

I can't reproduce crash in 4.0.dev.custom_build. ba048b8

@AndreaCatania
Copy link
Contributor

I've fixed this issue in bullet with this PR: bulletphysics/bullet3#3799. However, not sure this is still relevant anyway, so we may consider to close this or change to "update bullet".

@pouleyKetchoupp
Copy link
Contributor Author

@AndreaCatania Amazing! We can keep this open, since it's still an issue until we update Bullet. I'll add a tag in the title to make it clear.

@pouleyKetchoupp pouleyKetchoupp changed the title [Bullet] Crashing asserts in debug when using Bullet Physics with CCD enabled [Bullet] [Need Bullet Update] Crashing asserts in debug when using Bullet Physics with CCD enabled Apr 27, 2021
@pouleyKetchoupp pouleyKetchoupp changed the title [Bullet] [Need Bullet Update] Crashing asserts in debug when using Bullet Physics with CCD enabled [Bullet] [Needs Bullet Update] Crashing asserts in debug when using Bullet Physics with CCD enabled Apr 27, 2021
akien-mga added a commit to akien-mga/godot that referenced this issue Sep 30, 2021
Stop include Bullet headers using `-isystem` for GCC/Clang as it misleads
SCons into not properly rebuilding all files when headers change.

This means we also need to make sure Bullet builds without warning, and
current version fares fairly well, there were just a couple to fix (patch
included).

Increase minimum version for distro packages to 2.90 (this was never released
as the "next" version after 2.89 was 3.05... but that covers it too).

Fixes godotengine#43868.

(cherry picked from commit b7901c7)
@akien-mga akien-mga modified the milestones: 4.0, 3.4 Sep 30, 2021
@akien-mga
Copy link
Member

akien-mga commented Sep 30, 2021

Fixed by #48300 (and fix included in master, though bullet is disabled, in #48299).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants