Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent EditorImportPlugin extensions detection in FileSystem Dock #52995

Closed
Rubonnek opened this issue Sep 24, 2021 · 2 comments
Closed

Inconsistent EditorImportPlugin extensions detection in FileSystem Dock #52995

Rubonnek opened this issue Sep 24, 2021 · 2 comments
Labels
bug confirmed regression topic:editor topic:import topic:plugin
Milestone
4.0

Comments

@Rubonnek
Copy link
Member

Rubonnek commented Sep 24, 2021 •
edited
Loading

Godot version

3.x branch at 23bb588

System information

Arch Linux

Issue description

Registered EditorImportPlugin extensions are no longer showing up consistently in the FileSystem Dock on subsequent Editor restarts.

Seems to be caused by #52344, which is related to issue #52968.

Steps to reproduce

  1. Open the attached project.
  2. Search for 'tmx' on the FileSystem Dock -- only the file level1.tmx should show up and if it does, move to step 3. If level1.tmx doesn't show up on the search, the issue has been reproduced.
  3. Close the attached project.
  4. Repeat steps 1 through 3 until the issue has been reproduced in step 2. The issue can usually be reproduced within 10 tries or so.

Minimal reproduction project

editor_import_extension_not_showing.zip
@Rubonnek
Copy link
Member Author

CC @TechnoPorg.

@Rubonnek Rubonnek modified the milestones: 3.3, 3.4 Sep 24, 2021
@Calinou Calinou added this to the 3.4 milestone Sep 24, 2021
akien-mga added a commit to akien-mga/godot that referenced this issue Sep 27, 2021
@akien-mga
Revert "Load assets before enabling editor plugins"
abe0535 
This reverts commit 55f9ae3.

It caused regressions godotengine#52968 and godotengine#52995.
akien-mga added a commit that referenced this issue Sep 27, 2021
@akien-mga
Revert "Load assets before enabling editor plugins"
55e614a 
This reverts commit 5dcf325.

It caused regressions #52968 and #52995.
@akien-mga akien-mga mentioned this issue Sep 27, 2021
Merged
@akien-mga akien-mga modified the milestones: 3.4, 4.0 Sep 27, 2021
@akien-mga
Copy link
Member

Same as #52968 (comment), I reverted the change in 3.3 and 3.x so this should now only affect master.

sairam4123 pushed a commit to sairam4123/godot that referenced this issue Nov 10, 2021
@akien-mga @sairam4123
Revert "Load assets before enabling editor plugins"
d9c51aa 
This reverts commit 55f9ae3.

It caused regressions godotengine#52968 and godotengine#52995.
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this issue Dec 18, 2021
@akien-mga @lekoder
Revert "Load assets before enabling editor plugins"
3d0700b 
This reverts commit 55f9ae3.

It caused regressions godotengine#52968 and godotengine#52995.
@TechnoPorg TechnoPorg mentioned this issue Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed regression topic:editor topic:import topic:plugin
Projects
3.x release management
Archived in project
Milestone
4.0
Development

No branches or pull requests
3 participants
@Calinou @akien-mga @Rubonnek