Import assets before loading editor plugins

[TechnoPorg]

Hopefully fixes #36713!
This time, the addons folder is scanned first by the EditorFileSystem, then addons (including import plugins) are loaded, then the EditorFileSystem is updated and scans the rest of the project. This approach should prevent the regressions present in #52344: #52968 and #52995. I've tested this with an admittedly thrown together project, and I'm not experiencing them. I don't have an MRP for #36713 that works in 4.0 alpha, so I'm marking this PR as draft since I haven't tested whether it fixes what it's supposed to fix 😕 . If someone can test it, that would be great, but I probably should be keeping a separate 3.x clone on my computer anyways to use.

[akien-mga]

That's an interesting approach that should indeed solve most situations.

We need to check whether it's actually mandatory for editor plugins to reside in the res://adons folder though. If not, then this wouldn't work for plugins which have been placed somewhere else (either from a manual download or ad hoc plugins written for the project directly).

[TechnoPorg]

If not, then this wouldn't work for plugins which have been placed somewhere else (either from a manual download or ad hoc plugins written for the project directly).

Yeah, that occurred to me after submitting this PR as well. I believe this is in fact the case, based on a tweet Juan made a while ago: https://twitter.com/reduzio/status/1418659366438309896?s=20

[TechnoPorg]

I've changed my approach, to be more flexible with addon locations. I'd be surprised if things still work properly after this, though, since I don't fully understand the code here. Feedback from plugin wizards would be appreciated.

[reduz]

The idea in general is that addons for these kinds of things should slowly be deprecated in favor of extensions, and there should be a way for scripts to be able to do this beforehand too. I think this needs a bit more discussion so it can be done in a cleaner way.

[TechnoPorg]

The idea in general is that addons for these kinds of things should slowly be deprecated in favor of extensions, and there should be a way for scripts to be able to do this beforehand too. I think this needs a bit more discussion so it can be done in a cleaner way.

Do you mean that editor plugins with custom importers should be deprecated in favor of native extensions? If so, I think assets should still be loaded first, in case a native extension tool loads an asset. Sorry in advance for not understanding this better.

[TechnoPorg]

I'm wondering if a better approach might be to treat the filesystem like an optional cache, if the first scan isn't complete. What I mean by that is, when a resource is being loaded, check to see if it's been imported, but if it hasn't, and the first scan isn't complete, then try to import it. I don't believe this would cause any more slowdown than the approach currently here, since all assets used by editor plugins would have to be imported first anyways.

[TechnoPorg]

Since this doesn't seem to be a great solution, I'm going to close my pull request. If there's anything different I can do in the future to help fix the bug, please let me know!