Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling script template is not remembered after editor restart #67988

Closed
KoBeWi opened this issue Oct 28, 2022 · 5 comments · Fixed by #69443
Closed

Disabling script template is not remembered after editor restart #67988

KoBeWi opened this issue Oct 28, 2022 · 5 comments · Fixed by #69443

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Oct 28, 2022

Godot version

4.0 11e1bac

System information

Windows 10 x64

Issue description

When you disable script template to have an empty script, it will only be remembered until you exit the editor. Next time you will have to disable it again. Pretty sure it wasn't like that when the feature was implemented for the first time.

Steps to reproduce

  1. Add script to node
  2. Uncheck this
    image
  3. Restart the editor
  4. It's enabled again

Minimal reproduction project

No response

@dalexeev
Copy link
Member

It looks like this is not a regression, but an initially unimplemented behavior.

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 30, 2022

I reviewed and approved the original implementation (#53957) and according to the comments it was implemented at some point. I remember, because I specifically requested it.

@dalexeev
Copy link
Member

Indeed, this was originally implemented, but then was accidentally removed in #59603.

@dalexeev
Copy link
Member

I'm not entirely sure what templates_dictionary is for, but it looks like that logic has been removed as well.

https://github.com/godotengine/godot/pull/59603/files#diff-265788e1751b9ed8b0ec9dad4e96ecbfd7a85457b078e13bfaccd053eb2cf858L600-L603

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 30, 2022

I left a comment in #59603. That PR was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants