Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember Template checkbox in Create Script Dialog #68045

Conversation

dalexeev
Copy link
Member

Closes #67988.

@dalexeev dalexeev force-pushed the editor-remember-template-checkbox branch from 71a1017 to 6d824ea Compare October 30, 2022 11:09
@KoBeWi
Copy link
Member

KoBeWi commented Oct 30, 2022

This will work per-project, not globally like it used to before.

@dalexeev
Copy link
Member Author

This will work per-project, not globally like it used to before.

It seems to me that this is a more correct option, since different projects may have different templates. In addition, quite a lot of other metadata of the editor is also bound per project, not globally (for example, advanced mode of the Project Settings editor, dialog rects).

Perhaps this case (removing the necessary metadata in #59603) happened only because the set_meta solution looks more like a hack, due to the fact that there is set_project_metadata.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 30, 2022

It seems to me that this is a more correct option, since different projects may have different templates.

Well my problem is that whenever I open a project for the first time, I always use the default template by mistake, until I finally set empty template after a few scripts. It was annoying to me and I was very happy when #53957 finally resolved this issue. Templates for node type can be per-project, but disabling templates altogether should be a global thing.

the set_meta solution looks more like a hack

idk, I thought it's a clever solution when I first seen it, because it allows to have editor settings that don't show in the settings dialog. Although you can probably achieve the same by using _.

@YeldhamDev
Copy link
Member

the set_meta solution looks more like a hack

idk, I thought it's a clever solution when I first seen it, because it allows to have editor settings that don't show in the settings dialog.

set_meta would still be fine as long it's properly commented as to why it's being used.

@akien-mga
Copy link
Member

Superseded by #69443.

@akien-mga akien-mga closed this Dec 1, 2022
@dalexeev dalexeev deleted the editor-remember-template-checkbox branch December 1, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling script template is not remembered after editor restart
4 participants