Restore metadata to script create dialog #69443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 1, 2022
|
To see the fix properly, it could be meaning to have this as two commits: One |
KoBeWi
force-pushed
the
meta_never_dies
branch
from
25aa8ea
to
06465e3
Compare
akien-mga
approved these changes
Dec 1, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53957 used a small trick to store editor-wide settings in a way that isn't exposed to the settings dialog. It used metadata and was later broken after #59452, because it made slashes no longer allowed in metadata names. The errors were fixed in #59603, but it was not a correct fix, because it made the choices no longer remembered between sessions.
This PR reverts #59603 and fixes the original problem, i.e. invalid metadata names.
Fixes #67988
Supersedes #68045