Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection visual at end of the line inconsistent #72265

Closed
aXu-AP opened this issue Jan 28, 2023 · 0 comments · Fixed by #72341
Closed

Selection visual at end of the line inconsistent #72265

aXu-AP opened this issue Jan 28, 2023 · 0 comments · Fixed by #72341

Comments

@aXu-AP
Copy link
Contributor

aXu-AP commented Jan 28, 2023

Godot version

v4.0.beta.custom_build [3a25148], v3.5.1.stable.official [6fed1ff]

System information

Windows 10

Issue description

Visuals for selected text in code editor has 2 flaws in it's logic. I think they're linked so this issue covers both (but I can split it into 2 separate issues if that's better).
First: If selection ends at empty line, carriage return after the cursor is shown as selected:
cr-start

Above: Godot script editor, below: VS Code

Second: Carriage return at the end of selected lines is not shown (notice ambiguity - what happens if I press delete?):
cr-end

Above: Godot script editor, below: VS Code

The behaviour seems to be consistent across other editors - I've tested on VS Code, Visual Studio and Notepad++

Steps to reproduce

Open script editor and select text.

Minimal reproduction project

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants