Fix code editor moving lines without selected characters #72672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the selection ends at the start of new line, move_lines_up/down shouldn't affect that line. Add helper functions to get lines that are affected by line operations.
This was referenced Feb 3, 2023
This was referenced Feb 3, 2023
|
Work moved into #72671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54362
Supersedes #72270 and #54392
When the selection ends at the start of new line, move_lines_up/down shouldn't affect that line. Makes more sense with empty lines once #72265 gets fixed.
Function and code logic is the same as #72270, but this refactors line selection logic to a separate function.
Add helper functions to get lines that are affected by line operations. These are used in other similiar operations (#72679, #72675, #72671). These likely need to be rebased after one of them gets merged.