Fix CodeTextEditor.toggle_bookmark with multiple selections #72679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug if 2 carets are on the same line. Allow adding/removing all bookmarks on selected lines. Add helper functions to get lines that are affected by line operations.
This was referenced Feb 3, 2023
|
Work moved into #72671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #72410
Fix bug if you toggle bookmarks when 2 carets are on the same line.
A cool side effect, and maybe the more important feature is that you can now remove all bookmarks in selected lines (so you can clear all bookmarks in script simply by
ctrl+A+ctrl+alt+B). This works in inverse too, altough bookmarking multiple lines at once isn't all that useful, I would expect that to happen if I make a selection and press toggle bookmark.Add helper functions to get lines that are affected by line operations. These are used in other similiar operations (#72675, #72671, #72672). These likely need to be rebased after one of them gets merged.