Fix CodeTextEditor.delete_lines affecting lines without selected characters
#72379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acters Delete lines operation would delete one extra line if selection ends at new line. This fixes that. Also fixes some typos in delete_lines.
|
LGTM, it's the same logic as the approved PR |
|
I'm currently rewriting this to solve a few more issues, so this can be put on hold. |
|
Superseded by #72671. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #72671
Delete lines operation would delete one extra line if selection ends at new line. This fixes that. Also fixes some misspellings in
delete_lines.I didn't open a separate issue for this, but it's similiar to #54362. Also makes more sense with empty lines once #72265 gets fixed. So this completes my three part venture to make an already great code editor a bit more robust :)