Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKER] Blending with AnimationPlayer is not working correctly #73537

Open
4 of 8 tasks
TokageItLab opened this issue Feb 17, 2023 · 7 comments
Open
4 of 8 tasks

[TRACKER] Blending with AnimationPlayer is not working correctly #73537

TokageItLab opened this issue Feb 17, 2023 · 7 comments

Comments

@TokageItLab
Copy link
Member

TokageItLab commented Feb 17, 2023

Issue description

This is a tracker for a problem with AnimationPlayer blending not working as expected.

May be fixed by:

Backlink to the tracker tracker. https://github.com/orgs/godotengine/projects/58/views/3

Tasks

Preview Give feedback
  1. bug topic:animation
    TokageItLab
  2. bug topic:animation
  3. archived bug regression topic:animation
  4. bug topic:core
  5. discussion topic:core
  6. discussion documentation topic:animation
  7. bug enhancement topic:animation usability
  8. bug topic:animation

If there is anything else, please comment.

@limbonaut
Copy link
Contributor

#76127 is related.

@9cg
Copy link

9cg commented May 9, 2023

It doesn't show the correct behaviour locally. Strangely, other players see the expected behaviour in multiplayer when AnimationPlayer is synchronised with MultiplayerSynchronizer.

@TokageItLab TokageItLab modified the milestones: 4.1, 4.2 Jun 1, 2023
@TokageItLab
Copy link
Member Author

The most major issues have been resolved, but some of the rest will need a bit major fixes for minor updates, so I would punt them to 4.3.

@TokageItLab TokageItLab modified the milestones: 4.2, 4.3 Oct 15, 2023
@TokageItLab TokageItLab modified the milestones: 4.3, 4.x Jan 16, 2024
@TokageItLab TokageItLab removed their assignment Jan 16, 2024
@bertodelrio256
Copy link

I'm using 4.3 and noticed intermittently the custom blend time when calling .play() is ignored/defaulted. weird thing is I tried to create an MRP calling .play() at different times with different blend times, but it seemed to work fine so I canceled the issue. but in my production project, I'm seeing some blends just being ignored while others work fine. perhaps I'm not understanding how it works.. my assumption is the if I call .play("anim1", 0.3f) in process and then called .play("anim2", 3.0f) it should take 3 seconds to blend to that one right? I'm making many calls to animations before they finish with different blend times, could that be causing the issue? does the blend need to be reset somehow first?

@TokageItLab
Copy link
Member Author

TokageItLab commented Sep 30, 2024

I'm making many calls to animations before they finish with different blend times

@bertodelrio256 If you are calling the same animation many time before finish blending, I assume there is some problem, related #72484.

@bertodelrio256
Copy link

bertodelrio256 commented Sep 30, 2024

I'm making many calls to animations before they finish with different blend times

@bertodelrio256 If you are calling the same animation many time before finish blending, I assume there is some problem, related #72484.

ahh interesting. So a queue is filled when calling multiple. I think my issue could be resolved perhaps by only doing one call to .play() per physics tick and just have my states just change the string that it uses for that one call.

anyway looking forward to what you come up with in the new blending system. I hate using animation trees. honestly being able to everything in code would be a dream.

@bertodelrio256
Copy link

I just wanted to mention that I was able to resolve all of the blending issues by only calling .play once if the animation changed. looks like you cannot call .play every frame or the blends wont work...

if(anim_player.AssignedAnimation != current_clip)
		{
			anim_player.Play(current_clip, current_clip_blend);
		}
		```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants