Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKER] Typos and UI Paper Cuts #91521

Open
6 tasks done
RedMser opened this issue May 3, 2024 · 9 comments
Open
6 tasks done

[TRACKER] Typos and UI Paper Cuts #91521

RedMser opened this issue May 3, 2024 · 9 comments

Comments

@RedMser
Copy link
Contributor

RedMser commented May 3, 2024

As per godotengine/godot-proposals#9648, this issue tracks tiny issues which can easily be fixed and are not opinionated changes. This includes:

  • A misspelling in the user interface or class reference
  • A misspelling in the code (comment, variable name, class name, etc. as long as it is not a breaking change)
  • Adding or tweaking the property hint of a property
  • Giving names to unnamed method arguments
  • Changing the "basic/advanced" status of Project Settings

It does NOT include any functional changes, such as refactoring or reordering code.
Purpose of tracking these is NOT for users to make PRs for fixing them directly, but rather:

  1. For maintainers to periodically fix all of the listed issues in larger batches, instead of doing small PRs for individual issues.
  2. For contributors that are already touching code near a known issue, to fix it while they're at it.

A task list is used to keep track of how many issues there are, but you can simply remove the bullet points when done instead of checking them, to keep this tracker clean and re-usable.

Typos

  • core/object/script_language.cpp
    • typo: characacteristics -> characteristics
  • editor/plugins/visual_shader_editor_plugin.cpp at _setup_node function
    • code style: camelCase should be snake_case
  • scene/gui/code_edit.cpp
    • typo: all_ocurence -> all_occurrences (local variable)

Other minor mistakes

  • doc/classes/Window.xml
    • Documentation of WINDOW_MODE_FULLSCREEN and WINDOW_MODE_EXCLUSIVE_FULLSCREEN was not synced with DisplayServer.xml equivalent. Both are missing the line [b]On Android:[/b] This enables immersive mode.
  • doc/classes/String.xml
    • Missing link to class:
    -To convert any Variant to or from a string
    +To convert any [Variant] to or from a string

Functional changes

  • core/string/translation.cpp inside of TranslationServer::setup()
    • Add property hint ProjectSettings::get_singleton()->set_custom_property_info(PropertyInfo(Variant::STRING, "internationalization/locale/test", PROPERTY_HINT_LOCALE_ID, ""));

Maintainers are free to edit this issue to add to the list or change wording.
Other contributors are welcome to write comments and they'll be taken into account.

@LunarTides

This comment was marked as resolved.

@tetrapod00

This comment has been minimized.

@tetrapod00

This comment has been minimized.

@EAinsley

This comment has been minimized.

@RedMser

This comment has been minimized.

@AThousandShips

This comment has been minimized.

@EAinsley

This comment has been minimized.

@AThousandShips

This comment has been minimized.

@akien-mga
Copy link
Member

akien-mga commented Nov 28, 2024

All currently listed typos / minor issues should be handled by #99799 (aside from the vformat suggestion, but that one is outside the scope of this tracker IMO, and also not a no brainer as currently vformat can be quite expensive).

Note: Please avoid starting long discussions of suggestions in this tracker, which makes it harder to use as a laundry list of things to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants