Prevent SubViewports Update Mode from resetting on visibility changes #100076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes potentially undesired resets of render_target_update_mode, see godotengine#23729 and godotengine#71227
|
This completely breaks 2D editor. The scene is not rendering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes potentially undesired resets of render_target_update_mode on visibility changes.
see #23729 and #71227
First commit btw so I assume I didn't do something correct or informaly, please let me know how...
I think this line has either been an oversight or is simply a leftover from before other render_target_update_modes were implemented or planned.