-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SubViewportContainer's adjustments optional #71227
base: master
Are you sure you want to change the base?
Conversation
I would argue it probably would be better to simply the behavior by ensuring Godot is not changing the value of
|
Update mode is handled on RenderingServer side. It can't be an internal flag. EDIT: |
Well from user perspective internal flag makes it behave exactly like they would expect (disabling processing when SubViewportContainer is hidden), while respecting |
799c583
to
a48ae95
Compare
a48ae95
to
3825eb6
Compare
Rebased. I also tweaked EDIT: |
3825eb6
to
f43d910
Compare
Removes potentially undesired resets of render_target_update_mode, see godotengine#23729 and godotengine#71227
This PR improves documentation about properties modified by SubViewportContainer and makes this behavior optional by adding
adjust_viewport_properties
property.Closes #56502
Closes #23729