Push some warnings for CSG non manifold and other errors.

[fire]

@BastiaanOlij mentioned that seeing the error message for invalid CSGMesh inputs was complex.

This was also a leftover task from Fix mesh corruption of CSG by using #94321

I'm not perfectly happy with the warning wording. You are welcome to suggest changes.

Part of #100014

See also #100164

https://github.com/user-attachments/assets/f3080d1e

[fire]

Question, should child nodes error if their root id broken?

[Zireael07]

I say yes, to make it SUPER clear to user that things are broken

[fire]

@Zireael07 enhanced

[SpockBauru]

I don't think people will know what manifold means, maybe pointing a link to the CSG docs or just explaining that is not a "closed mesh" is better. "Manifold" is too cryptic.

[fire]

Thanks for the review! I'll try to put the entire definition in a short way.

[fire]

This is a draft error message. Will try it.

Edit 12.

[SpockBauru]

Tested the windows artifact.

The warning does not appear when you set an invalid mesh, it only changes if there are changes in the tree. It also doesn't disappear when set a valid mesh.

Also when hovering the mouse the line in the in bottom is not splitting and goes over the screen limit of the monitor.

CSG_warning.mp4

[fire]

The csg tree modification error is a different bug which has a pull request. #100340

[fire]

Also when hovering the mouse the line in the in bottom is not splitting and goes over the screen limit of the monitor.

I wish I had some ideas with shorter wording, but I was stuck on the words.

My phrasing is too long, and the tooltip is not cutting the text.

[fire]

@SpockBauru Can you retest after the build is done?

[SpockBauru]

Tested the Windows artifact and there are no changes on my end, the hint box still goes over the screen limit.

Edit: Warning box:

[tetrapod00]

Suggested change

	"A manifold mesh forms a solid object without gaps, holes, or loose edges. "
	"For a mesh to be manifold, every edge of every triangle must contain the same two vertices (by index) as exactly one other triangle edge, "
	"and the start and end vertices must switch between these two edges. The Godot Engine triangle vertices must appear in clockwise order "
	"when viewed from the outside of the mesh.";
	"A manifold mesh forms a solid object without gaps, holes, or loose edges. Each edge must connect to exactly two faces."

or

Suggested change

	"A manifold mesh forms a solid object without gaps, holes, or loose edges. "
	"For a mesh to be manifold, every edge of every triangle must contain the same two vertices (by index) as exactly one other triangle edge, "
	"and the start and end vertices must switch between these two edges. The Godot Engine triangle vertices must appear in clockwise order "
	"when viewed from the outside of the mesh.";
	"A manifold mesh forms a solid object without gaps, holes, or loose edges. Each edge must be a member of exactly two faces."

I feel like this is about the right amount of information to put in a warning message: a one or two sentence summary, in friendly and relatively non-technical language.

Even as someone who understands all the concepts, the full-length message is very intimidating. My eyes start to glaze over as I read it. If we need a long and technical explanation like that, it should be in the docs somewhere, not in a warning popup.

Maybe we can put it in the manual, along with some tips on how to troubleshoot non-manifold meshes.

[fire]

@tetrapod00 I have a draft of the process for making manifold shapes using Blender's fixing tool. https://docs.google.com/document/d/11KPDwMuZl3c4NSwanhatekAIvUxktURmXJVPkP_a17o/edit?tab=t.0#heading=h.r41iui30hwv7

[SpockBauru]

Tested the windows artifact, the new wording seems to be good enough, it roughly explains the issue and the hint box does not goes over the screen limit anymore :D

Seems like #100340 has been merged. Is that applied to this PR? Because I'm still not triggering the error message when selecting an invalid mesh. The error icon only appears when there are changes in the tree, not in the mesh itself.

[fire]

Setting a mesh on csgmesh3d still is broken with respect to updating war ings

[fire]

I can now move the CSG nodes around and keep the warnings, but I lost the specific error message, and setting a mesh on a CSGMesh3D still does not update until the scene reloads.

[SpockBauru]

Tested the Windows artifact, the new tooltip is a way more readable:

[0xafbf]

For the explanation of the two edges, I think it can be useful to refer to the normals of the faces for explaining the concept of manifold. I suggest something like this:

Every edge of every triangle should link exactly two triangles, and the normals of the triangles should always face outwards

Although I don't know if all-inward faces are allowed. but still, saying "all inward or all outward" should be clear I think.

[fire]

The nuance about all the triangles being in the same winding order (like clockwise) from outside the object was removed because it was too technical. The 3mf manifold definition doesn’t require normals.

Edited:

https://github.com/elalish/manifold/wiki/Manifold-Library#manifoldness

[akien-mga]

Thanks!