Buildsystem improvements for the Mono module #12388
Conversation
neikeq
commented
Oct 24, 2017
•
neikeq
commented
- Make sure to search the mono installation directory for the right architecture in the windows registry.
- Do not build GodotSharpTools directly to #bin dir. Instead build to the default output path and copy it. This way we avoid MSBuild adding files we don't want to #bin.
- Add hint path for MSBuild in OSX.
- Copy shared library on Unix if not statically linking.
- Use vswhere to search MSBuild and search for 14.0 tools version in the registry instead of 4.0.
- SCons will only fallback xbuild when msbuild is not found if 'xbuild_fallback=yes' is passed to the command.
- Use mono's assembly path as FrameworkPathOverride if using with system's MSBuild (not mono's fork).
- Cleanup.
modules/mono/SCsub
Outdated
| @@ -1,121 +1,150 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Not sure what's wrong with this diff...
There was a problem hiding this comment.
Yes, that's the file before and after your patch:
$ file modules/mono/SCsub
modules/mono/SCsub: Python script, ASCII text executable
$ git apply ~/Downloads/df950b9a2950d854d0c14de966856d6296fa8dcb.patch
[...]
$ file modules/mono/SCsub
modules/mono/SCsub: Python script, ASCII text executable, with CRLF line terminators
|
This change will make it difficult for me to make alpha2 binaries, since I can't find a way to build MSBuild from source and I need to be able to generate the glue. What are the problems with xbuild? Deprecating the only buildsystem that can be easily compiled from source for now is not a smart move IMO. That means that we can only build Godot on the platforms which are lucky enough to get official Mono repos/installers (Windows, macOS, Ubuntu/Debian/CentOS), so all other Linux distros are out. Until there are clear instructions either upstream or in our docs regarding how to build MSBuild, I'd prefer we keep support for xbuild. |
|
BTW, regardless of whether we keep support for xbuild for now, |
neikeq
force-pushed
the
r
branch
3 times, most recently
from
37f2676 to
265c00b
Compare
|
Updated. In order to build with xbuild if msbuild is not found, you will have to pass |
- Make sure to search the mono installation directory for the right architecture in the windows registry. - Do not build GodotSharpTools directly to #bin dir. Instead build to the default output path and copy it. This way we avoid MSBuild adding files we don't want to #bin. - Add hint path for MSBuild in OSX. - Copy shared library on Unix if not statically linking. - Use vswhere to search MSBuild and search for 14.0 tools version in the registry instead of 4.0. - SCons will only fallback xbuild when msbuild is not found if 'xbuild_fallback=yes' is passed to the command. - Use mono's assembly path as FrameworkPathOverride if using with system's MSBuild (not mono's fork). - Cleanup.
