Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Tileset save causing crash #12708 #12732

Closed
Closed
Changes from 5 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4045bc1
Fix "Invalid outputs" error when calling a void method from visual sc…
bojidar-bg Nov 8, 2017
b7fd065
Fix crash when guessing type of variable declared to itself
bojidar-bg Nov 8, 2017
0b7ae36
Fix tilemap undo/redo
Zylann Nov 8, 2017
7c85446
Fixed issue #12708 Empty Scene Tileset causing crash
Nov 7, 2017
967b3db
Fixed issue #12708 Empty Scene Tileset causing crash.
Nov 7, 2017
b37e277
Fixing bad index used in Space2DSW
MateusMP Nov 8, 2017
48adeac
Merge branch 'bug_checking' of https://github.com/CalebMRichardson/go…
Nov 8, 2017
57256ce
Merge branch 'bug_checking' of https://github.com/CalebMRichardson/go…
Nov 8, 2017
2e7dd7b
Merge branch 'bug_checking' of https://github.com/CalebMRichardson/go…
Nov 8, 2017
09a1d01
[DOCS] Object
NathanWarden Nov 7, 2017
b87a7df
Merge pull request #12733 from NathanWarden/document_object
cbscribe Nov 9, 2017
7e0e415
Merge pull request #12755 from Zylann/fix_tilemap_undo
akien-mga Nov 9, 2017
355c8fd
Merge pull request #12752 from bojidar-bg/10972-recusion-completion
akien-mga Nov 9, 2017
5f805de
Merge pull request #12751 from bojidar-bg/11851-invalid-returns-count
akien-mga Nov 9, 2017
05fc741
Merge pull request #12757 from MateusMP/bugfix/11695
akien-mga Nov 9, 2017
7664a0f
unified headers fix
rraallvv Nov 8, 2017
e25b6bf
fix dictionary constant access crash
karroffel Nov 7, 2017
c7cd89c
Merge pull request #12780 from karroffel/dictionary-crash
akien-mga Nov 9, 2017
423f299
Enable asset store for godot 3.0
Chaosus Nov 9, 2017
d7add01
Merge pull request #12778 from Chaosus/enableassetstore
akien-mga Nov 9, 2017
e4effb4
Merge pull request #12746 from rraallvv/unified_headers_fix
akien-mga Nov 9, 2017
7957bbf
add missing distutils.version.LooseVersion import
rraallvv Nov 9, 2017
d09160a
Make video mode initialization more intuitive, fixes #12022
reduz Nov 9, 2017
2507818
Merge pull request #12782 from rraallvv/unified_headers_fix
akien-mga Nov 9, 2017
5cb1d06
fixes to initialization order
reduz Nov 9, 2017
98e6d8c
Fixed issue #12708 Empty Scene Tileset causing crash
Nov 7, 2017
74663ba
Merge branch 'bug_checking' of https://github.com/CalebMRichardson/go…
Nov 9, 2017
966885d
Fixed Tileset Save Causing Crash #12708 (Fix to respect Clang)
Nov 9, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions editor/editor_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1932,6 +1932,15 @@ void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) {

} break;
case FILE_EXPORT_TILESET: {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary indentation here (empty line), that's why Travis rejects it.

//Make sure Scene has a root before trying to convert to tileset
if (!editor_data.get_edited_scene_root()) {
current_option = -1;
accept->get_ok()->set_text(TTR("I see.."));
accept->set_text(TTR("This operation can't be done without a root."));
accept->popup_centered_minsize();
break;
}

List<String> extensions;
Ref<TileSet> ml(memnew(TileSet));
Expand Down